Federico Mena Quintero [Tue, 29 Jan 2013 07:14:10 +0000 (01:14 -0600)]
Redo the logic for computing drop positions
Instead of having an accept_uri_drops flag, we'll always advertise as accepting URI drops.
However, we'll see if the caller actually handles the drag-action-requested signal. If it
does, we'll indeed allow performing file operations when URIs are dropped. Otherwise,
we'll only allow creating bookmarks from dragged URIs.
Dragging URIs directly into a places item will cause the sidebar to check if the caller
allows file operations. Dragging URIs between places items will cause the sidebar
to create bookmarks for those URIs instead.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Tue, 29 Jan 2013 07:02:57 +0000 (01:02 -0600)]
Whitespace cleanups
Federico Mena Quintero [Sat, 26 Jan 2013 00:01:42 +0000 (18:01 -0600)]
Reset the treeview drag dest row if the drop is not possible
This keeps the drop indicator line from 'sticking' if you drag a bookmark above
the Bookmarks heading.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Fri, 25 Jan 2013 00:46:07 +0000 (18:46 -0600)]
Remove TODO items that are done
Federico Mena Quintero [Mon, 21 Jan 2013 23:59:23 +0000 (17:59 -0600)]
Use GFile in the DnD signals instead of URIs
The rest of the public API works in terms of GFile, so remove this last remnant
of passing URIs around.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Cosimo Cecchi [Mon, 21 Jan 2013 23:23:25 +0000 (18:23 -0500)]
Add some missing annotations
Cosimo Cecchi [Mon, 21 Jan 2013 23:21:00 +0000 (18:21 -0500)]
Add GObject properties and C getters
Cosimo Cecchi [Mon, 21 Jan 2013 23:04:14 +0000 (18:04 -0500)]
Remove useless style_set override
Cosimo Cecchi [Mon, 21 Jan 2013 22:48:47 +0000 (17:48 -0500)]
Update TODO
Cosimo Cecchi [Mon, 21 Jan 2013 22:38:34 +0000 (17:38 -0500)]
Apply custom names to XDG dirs if possible
And make it possible to rename them
Cosimo Cecchi [Mon, 21 Jan 2013 22:33:22 +0000 (17:33 -0500)]
Don't add built-in bookmarks twice
Cosimo Cecchi [Mon, 21 Jan 2013 22:32:02 +0000 (17:32 -0500)]
Add API to GtkBookmarksManager for built-in bookmarks
I.e. those that are added automatically from XDG dirs.
Cosimo Cecchi [Mon, 21 Jan 2013 22:12:48 +0000 (17:12 -0500)]
Mark a function as static
Cosimo Cecchi [Mon, 21 Jan 2013 22:07:12 +0000 (17:07 -0500)]
Use g_clear_object()
Cosimo Cecchi [Mon, 21 Jan 2013 22:06:42 +0000 (17:06 -0500)]
Don't unconditionally unref potentially NULL objects
We already have != NULL checks here, so fold the unrefs inside.
Cosimo Cecchi [Mon, 21 Jan 2013 22:00:50 +0000 (17:00 -0500)]
Avoid an useless ref/unref
The GMount will be kept alive by the async operation itself.
Cosimo Cecchi [Mon, 21 Jan 2013 21:57:27 +0000 (16:57 -0500)]
Fix a FIXME about using symbolic icons
Use g_file_info_get_symbolic_icon() for it.
Cosimo Cecchi [Mon, 21 Jan 2013 21:48:52 +0000 (16:48 -0500)]
Sync from Nautilus commit
463e8d1b1922474e4cf591a3029ea813804bd3e7
make sure to always notify when unmounting
Cosimo Cecchi [Mon, 21 Jan 2013 21:38:23 +0000 (16:38 -0500)]
Sync from Nautilus commit
480b1daf8814063f348d0f75082353a2f6a3eab3
cancel the hostnamed proxy creation on dispose
Federico Mena Quintero [Sat, 19 Jan 2013 01:28:58 +0000 (19:28 -0600)]
Add some missing docs for GtkPlacesSidebar
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Fri, 18 Jan 2013 23:52:10 +0000 (17:52 -0600)]
Add GtkPlacesSidebar to the gtk-doc machinery
Federico Mena Quintero [Fri, 18 Jan 2013 23:18:25 +0000 (17:18 -0600)]
Add toplevel docs for the sidebar
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Fri, 11 Jan 2013 23:55:36 +0000 (17:55 -0600)]
Add docstrings for the signals
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Fri, 11 Jan 2013 02:07:27 +0000 (20:07 -0600)]
Add missing docstrings to public functions
Federico Mena Quintero [Fri, 11 Jan 2013 01:37:24 +0000 (19:37 -0600)]
Oops, removed unused icon field
Federico Mena Quintero [Fri, 11 Jan 2013 00:12:15 +0000 (18:12 -0600)]
Make the set_location()/get_location() API consistent
We used to have set_current_location() and get_selected_location(), with confusing
semantics. Now they are symmetric, with the exception that if set_location() is
called with a location that is not shown in the sidebar, then it will both clear
the selection in the list and make get_selection() return NULL.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Thu, 10 Jan 2013 22:19:03 +0000 (16:19 -0600)]
New API, gtk_places_sidebar_set_open_flags()
This lets us handle the 'Open in new tab' and 'Open in new window' menu items
on our own, and allows callers to have less code to deal with each mode.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Thu, 10 Jan 2013 21:06:01 +0000 (15:06 -0600)]
Use GtkTrashMonitor instead of an API to set the trash state
This lets us remove two entry points, gtk_places_sidebar_set_show_trash(),
and gtk_places_sidebar_set_trash_is_full().
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Thu, 10 Jan 2013 20:36:27 +0000 (14:36 -0600)]
Add a GtkTrashMonitor private API
This is analogous to NautilusTrashMonitor in that it just monitors trash:///
and is able to return the appropriate icon for the trash's current state.
Later we may want to move this utility object into GIO or something.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Tue, 8 Jan 2013 22:34:15 +0000 (16:34 -0600)]
Remove to-do items for Nautilus; they are done now
Federico Mena Quintero [Tue, 18 Dec 2012 02:05:23 +0000 (20:05 -0600)]
New public function to get the selected location from menu item callbacks
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Sat, 15 Dec 2012 03:44:50 +0000 (21:44 -0600)]
Emit the populate-popup signal so the caller can spice things up
Also, we factor out the process of getting the selected item's info out of
the liststore.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Sat, 15 Dec 2012 00:15:49 +0000 (18:15 -0600)]
Remove the Properties menu item
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Sat, 15 Dec 2012 00:08:50 +0000 (18:08 -0600)]
Remove the Empty Trash menu item
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Sat, 15 Dec 2012 00:04:30 +0000 (18:04 -0600)]
Remove the multiple-tab/windows-supported APIs
We'll have the caller do these instead via the populate-popup signal.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Fri, 14 Dec 2012 23:56:53 +0000 (17:56 -0600)]
Rebuild the popup menu every time it is used
We'll need to rebuild it every time for the populate-popup signal.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Fri, 14 Dec 2012 17:57:49 +0000 (11:57 -0600)]
New signal populate-popup
Instead of conditionally creating contextual menu items like 'Show file properties',
we'll instead let the caller populate the popup menu, as is done for GtkEntry.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Tue, 11 Dec 2012 21:52:17 +0000 (15:52 -0600)]
Remove gtk_places_sidebar_set_show_cwd(), implement that in the file chooser
This removes more idiosyncratic API from the sidebar.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Tue, 11 Dec 2012 21:29:11 +0000 (15:29 -0600)]
Remove the GError from the shortcut-related functions
See https://bugzilla.gnome.org/show_bug.cgi?id=650363#c8 and the next comment; this
argument just makes the API harder to use without real benefit.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Tue, 11 Dec 2012 18:09:13 +0000 (12:09 -0600)]
Rename signal location-selected to open-location
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Mon, 10 Dec 2012 23:28:07 +0000 (17:28 -0600)]
Remove another to-do
Federico Mena Quintero [Mon, 10 Dec 2012 23:26:46 +0000 (17:26 -0600)]
Implement the Search keyboard shortcut
We still lack a button to activate Search, like in Nautilus, but that will come later.
And with this, the last REMOVE_FOR_PLACES_SIDEBAR is gone!
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Mon, 10 Dec 2012 23:16:36 +0000 (17:16 -0600)]
Remove unused code
Federico Mena Quintero [Mon, 10 Dec 2012 23:14:12 +0000 (17:14 -0600)]
Go back to our machinery for Recent files instead of reading recent:/// as-is
Reading recent:/// as-is is probably fine for OPEN mode. But for SAVE mode, we want to present
a list of recent directories. So, we go back to our old machinery for now; in the future
we'll probably just use recent:/// and extract the list of recent directories from there.
This also fixes showing the Recent item as highlighted when the file chooser starts up.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Mon, 10 Dec 2012 22:05:18 +0000 (16:05 -0600)]
Remove an obsolete function
Federico Mena Quintero [Mon, 10 Dec 2012 22:00:42 +0000 (16:00 -0600)]
Implement the Alt-number quick bookmark shortcuts
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Mon, 10 Dec 2012 20:45:18 +0000 (14:45 -0600)]
Implement the Desktop keyboard shortcut
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Mon, 10 Dec 2012 20:23:06 +0000 (14:23 -0600)]
Implement the Home keyboard shortcut
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Mon, 10 Dec 2012 20:18:00 +0000 (14:18 -0600)]
Implement the 'Add to bookmarks' command as before
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Mon, 10 Dec 2012 20:09:40 +0000 (14:09 -0600)]
Remove an obsolete function
Federico Mena Quintero [Mon, 10 Dec 2012 19:48:42 +0000 (13:48 -0600)]
Implement the application-side shortcuts in GtkFileChooserDefault
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Fri, 7 Dec 2012 19:42:39 +0000 (13:42 -0600)]
New machinery to add application-specific shortcuts
The file chooser needs them for gtk_file_chooser_add_shortcut_folder() and friends.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Thu, 6 Dec 2012 18:11:30 +0000 (12:11 -0600)]
One less to-do
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Thu, 6 Dec 2012 00:09:44 +0000 (18:09 -0600)]
Remove the old shortcuts pane code from GtkFileChooserDefault
Oh, the giant void.
I stare into it
and it makes me afraid
that I've screwed up.
But I know I haven't.
Because any remaining bugs
will be yours to fix.
Not mine.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Thu, 6 Dec 2012 00:03:54 +0000 (18:03 -0600)]
Allow not setting a changed callback on GtkBookmarksManager
Federico Mena Quintero [Wed, 5 Dec 2012 23:44:49 +0000 (17:44 -0600)]
Remove obsolete comment
Federico Mena Quintero [Wed, 5 Dec 2012 23:44:14 +0000 (17:44 -0600)]
Sync from Nautilus commit
bde2536ee72672c4cd58af7cbb3cf42a42962c21
Use ellipsis character instead of dots
Federico Mena Quintero [Wed, 5 Dec 2012 22:56:15 +0000 (16:56 -0600)]
Sync from nautilus commit
b2e8339d9f49770db0f6a523c8bf77b11d7eace3
Simplify setting eject icon
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Wed, 5 Dec 2012 22:51:32 +0000 (16:51 -0600)]
Federico Mena Quintero [Wed, 5 Dec 2012 22:51:15 +0000 (16:51 -0600)]
Add list of pending things in GtkPlacesSidebar
Federico Mena Quintero [Wed, 5 Dec 2012 00:25:44 +0000 (18:25 -0600)]
Remove comments on things that Nautilus no longer needs to do
Federico Mena Quintero [Wed, 5 Dec 2012 00:18:32 +0000 (18:18 -0600)]
Use the right signal id
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Wed, 5 Dec 2012 00:09:38 +0000 (18:09 -0600)]
Removed unneeded signal initiated-unmount
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Wed, 5 Dec 2012 00:08:52 +0000 (18:08 -0600)]
Oops, forgot to commit this header file.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Tue, 4 Dec 2012 23:37:45 +0000 (17:37 -0600)]
Oops, signals returning an int must be G_SIGNAL_RUN_LAST
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Tue, 4 Dec 2012 22:16:49 +0000 (16:16 -0600)]
Port code to add a bookmark for a volume
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Tue, 4 Dec 2012 18:57:48 +0000 (12:57 -0600)]
New API to set whether URI drops are accepted
The file chooser will not accept dropping URIs in a shortcut item. However, Nautilus will,
to perform normal DnD for files.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Tue, 4 Dec 2012 18:52:44 +0000 (12:52 -0600)]
Emit drag-perform-drop when we need the caller to do the drop action
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Tue, 4 Dec 2012 18:44:46 +0000 (12:44 -0600)]
New signal drag-perform-drop
The caller is supposed to take action with the specified URIs.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Tue, 4 Dec 2012 00:15:41 +0000 (18:15 -0600)]
New signal drag-action-ask
We'll ask the caller to present a popup menu (or whatever) with the possible drag actions.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Mon, 3 Dec 2012 23:37:11 +0000 (17:37 -0600)]
Emit drag-action-requested and feed the result to gdk_drag_status()
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Mon, 3 Dec 2012 23:09:57 +0000 (17:09 -0600)]
New signal drag-action-requested
We'll use this signal to ask the caller about what drag action to indicate
when something is being hovered on an item in the places sidebar.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Mon, 3 Dec 2012 22:45:25 +0000 (16:45 -0600)]
Free URI lists
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Mon, 3 Dec 2012 22:41:02 +0000 (16:41 -0600)]
Rename function for clarity
build_selection_list() -> build_uri_list()
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Fri, 30 Nov 2012 17:08:08 +0000 (11:08 -0600)]
Remove the menu items to select recent-files or CWD
Per the gtk-devel meeting on 2012/11/29, we'll not have a UI in the file chooser dialog
to select between those modes. Instead, we'll show that key in gtweaktool.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Tue, 27 Nov 2012 02:43:23 +0000 (20:43 -0600)]
Ahem, read radio menu items like I knew how to do it
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Sat, 24 Nov 2012 17:18:23 +0000 (11:18 -0600)]
Restore the originally-selected location when dynamically updating the bookmarks
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Sat, 24 Nov 2012 16:59:48 +0000 (10:59 -0600)]
Oops, actually update the internal location of the places sidebar prior to notifying the caller
This is so that the sidebar will already know the URI of the location it is showing. When
the caller asks the sidebar to change back to the same location, the call will be idempotent.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Sat, 24 Nov 2012 16:41:40 +0000 (10:41 -0600)]
Highlight the currently-viewed location in the places sidebar
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Sat, 24 Nov 2012 16:41:11 +0000 (10:41 -0600)]
Turn gtk_places_sidebar_set_current_uri() into _set_current_location()
To be consistent with the ::location-selected signal, which emits a GFile, we now also use a GFile
instead of a string URI in the inbound API.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Fri, 23 Nov 2012 19:24:55 +0000 (13:24 -0600)]
Actually switch to recent:/// in its key shortcut handler
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Fri, 23 Nov 2012 18:53:35 +0000 (12:53 -0600)]
Allow switching to recent:/// even though GIO thinks it is not a native file
That URI is not a native file, and so it would not show up if local_only=TRUE.
Add a special case for it so that recent:/// can always be visited.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Wed, 21 Nov 2012 19:13:01 +0000 (13:13 -0600)]
Update the widgets until all of them have been created
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Wed, 21 Nov 2012 18:08:23 +0000 (12:08 -0600)]
Add menu items to the places sidebar to configure the startup mode
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Wed, 21 Nov 2012 16:40:34 +0000 (10:40 -0600)]
Switch to Recent Files or $CWD at startup
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Wed, 21 Nov 2012 16:28:26 +0000 (10:28 -0600)]
Add a new org.gtk.SettingsFileChooser startup-mode settings key
It has two possible values, 'recent' and 'cwd'. We will use these to determine
whether to set the default starting mode, if a folder has not been pre-set,
to showing the Recent Files list or the current working directory.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Wed, 21 Nov 2012 02:04:20 +0000 (20:04 -0600)]
New way to show in the sidebar
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Tue, 30 Oct 2012 00:57:24 +0000 (18:57 -0600)]
Note about missing empty-trash functionality when unmounting a volume.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Tue, 30 Oct 2012 00:53:41 +0000 (18:53 -0600)]
Fix code to unmount volumes
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Mon, 29 Oct 2012 20:28:12 +0000 (14:28 -0600)]
Copy code from Nautilus to mount volumes
Instead of having a nested-callback scheme (to preserve internal API compatibility),
we use a direct callback from g_volume_mount().
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Mon, 29 Oct 2012 17:52:34 +0000 (11:52 -0600)]
Set GTK_STYLE_CLASS_SIDEBAR on the sidebar
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Fri, 26 Oct 2012 23:53:09 +0000 (18:53 -0500)]
Remove some more comments on things that Nautilus needs to do
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Fri, 26 Oct 2012 18:05:56 +0000 (13:05 -0500)]
Remove some notes on things that Nautilus should do but already does
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Mon, 22 Oct 2012 23:21:17 +0000 (18:21 -0500)]
Add a show-file-properties signal for Nautilus to use
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Mon, 22 Oct 2012 22:53:32 +0000 (17:53 -0500)]
Note on more things that Nautilus needs to do
Federico Mena Quintero [Mon, 22 Oct 2012 22:52:27 +0000 (17:52 -0500)]
Present error dialogs from the places sidebar
Federico Mena Quintero [Sat, 20 Oct 2012 19:09:34 +0000 (14:09 -0500)]
Oops, reorder the bookmarks list correctly
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Sat, 20 Oct 2012 19:00:50 +0000 (14:00 -0500)]
Enable code to reorder bookmarks by dragging
Federico Mena Quintero [Sat, 20 Oct 2012 18:34:23 +0000 (13:34 -0500)]
Sync from Nautilus commit
b72d57b038e50172fac2fafdc6c26660378aab34
No changes (except a whitespace fix), for we already had a copy of
special_directory_get_gicon().
Federico Mena Quintero [Fri, 19 Oct 2012 17:26:40 +0000 (12:26 -0500)]
Add comment about missing way to get symbolic icons for bookmarks
Nautilus got the ability to do that in commit
0ed400b9c1692e42498bff3c10780073ec137f63.
Maybe we should just copy that code to here later.
projects / gtk4.git / log